[PATCH] D115861: [LoongArch 4/6] Add basic tablegen infra for LoongArch

Tue Feb 8 06:25:14 PST 2022

xen0n added inline comments.

================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchBaseInfo.h:36
+  OPERAND_SIMM16,
+  OPERAND_SIMM20,
+  OPERAND_LAST_LOONGARCH_IMM = OPERAND_SIMM20,
----------------
SixWeining wrote:
> xen0n wrote:
> > Sorry for noticing this late, but don't we have simm21 for BEQZ/BNEZ and simm26 for B/BL?
> Thanks. This patch is just to add basic tablegen infra, so not all kinds of operand type are added here. Branch and function call would be implemented in future and related operand types would be added then.
Hmm, looking at surrounding code and usages of the other defines here, it seems all "lsl2" operands are not represented here, but correctly referenced in the td files; is that inconsistency intentional? Because branch instructions are clearly present in the tables.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115861/new/

https://reviews.llvm.org/D115861