[PATCH] D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:466
 
     // If we found  that we need amdgpu-queue-ptr, nothing else to do.
+    if (NeedsQueuePtr)
----------------
sameerds wrote:
> arsenm wrote:
> > Reword comment to negate?
> Not really. "nothing else to do" simply means "return early" here.
amdgpu-queue-ptr isn't an attribute, amdgpu-no-queue-ptr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119087/new/

https://reviews.llvm.org/D119087