[PATCH] D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:413
 
-    // If we found that we need amdgpu-queue-ptr, nothing else to do.
     if (NeedsQueuePtr) {
----------------
arsenm wrote:
> Lost the comment?
The "nothing else to do" refers to the rest of the function body, which got moved into `checkForQueuePtr()`. The short-circuiting logical-or before calling this function is the same thing now. 


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:466
 
     // If we found  that we need amdgpu-queue-ptr, nothing else to do.
+    if (NeedsQueuePtr)
----------------
arsenm wrote:
> Reword comment to negate?
Not really. "nothing else to do" simply means "return early" here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119087/new/

https://reviews.llvm.org/D119087