[PATCH] D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:466
 
     // If we found  that we need amdgpu-queue-ptr, nothing else to do.
+    if (NeedsQueuePtr)
----------------
arsenm wrote:
> sameerds wrote:
> > arsenm wrote:
> > > Reword comment to negate?
> > Not really. "nothing else to do" simply means "return early" here.
> amdgpu-queue-ptr isn't an attribute, amdgpu-no-queue-ptr
Ah, I see. Just like the comment before this one, it is actually referring to "the queue pointer" and not the attribute. I didn't write this code ... git is confused about code that got moved up/down. There are multiple places in this file that still talk about "needs a queue ptr attribute" in the positive sense. Might be good to clean that up separately.

This patch merely moves stuff around and converts the hard-coded mask  bits into those generated from enums.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119087/new/

https://reviews.llvm.org/D119087