[PATCH] D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 06:20:37 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:413
 
-    // If we found that we need amdgpu-queue-ptr, nothing else to do.
     if (NeedsQueuePtr) {
----------------
Lost the comment?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:466
 
     // If we found  that we need amdgpu-queue-ptr, nothing else to do.
+    if (NeedsQueuePtr)
----------------
Reword comment to negate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119087/new/

https://reviews.llvm.org/D119087



More information about the llvm-commits mailing list