[PATCH] D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 31 10:10:41 PST 2022


jmorse added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/spill-slot-limits.mir:26-27
+## Test that if there's no limit, we _do_ get some locations.
+# NOLIMIT:      DBG_INSTR_REF 1, 0
+# NOLIMIT-NEXT: DBG_VALUE $esi
+#
----------------
Orlando wrote:
> I'm confused - why don't we see this initial non-spill location for the `-livedebugvalues-max-stack-slots=0` case (in regular `CHECK` directives above)?
The test spills to the stack and restores to $esi -- if we don't track it through the stack, there'll be no location. I suppose a clearer test would test each stage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118601/new/

https://reviews.llvm.org/D118601



More information about the llvm-commits mailing list