[PATCH] D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:166
+// When this happens, gracefully stop tracking excess spill slots, rather than
+// consuming all the developers memory.
+static cl::opt<unsigned>
----------------
nit: developers -> developer's


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:170
+                         cl::desc("livedebugvalues-stack-ws-limit"),
+                         cl::init(250));
+
----------------
I don't know what constitutes a reasonable cut-off for this. What made you choose 250?


================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/spill-slot-limits.mir:26-27
+## Test that if there's no limit, we _do_ get some locations.
+# NOLIMIT:      DBG_INSTR_REF 1, 0
+# NOLIMIT-NEXT: DBG_VALUE $esi
+#
----------------
I'm confused - why don't we see this initial non-spill location for the `-livedebugvalues-max-stack-slots=0` case (in regular `CHECK` directives above)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118601/new/

https://reviews.llvm.org/D118601