[PATCH] D118601: [DebugInfo][InstrRef] Add a max-stack-slots-to-track limitation / cut-out

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:170
+                         cl::desc("livedebugvalues-stack-ws-limit"),
+                         cl::init(250));
+
----------------
Orlando wrote:
> I don't know what constitutes a reasonable cut-off for this. What made you choose 250?
It's an educated guess -- I've been building some large C++ codebases with different limits (and with a compiler that aborts when it hits the limit) to try and find out what's reasonable. So far I've reached a limit of 30 without any "normal" builds failing. Still waiting for LTO builds to complete, which is the much more interesting case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118601/new/

https://reviews.llvm.org/D118601