[PATCH] D118321: [VE] LEGALAVL and staged VVP legalization

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 added a comment.

Please add more comments.



================
Comment at: llvm/lib/Target/VE/VECustomDAG.h:30-43
+Optional<int> getAVLPos(unsigned);
+
+bool isLegalAVL(SDValue AVL);
+
+SDValue getNodeAVL(SDValue);
+
+bool isVVPOrVEC(unsigned);
----------------
It's better to have more descriptions of these AVL stuff.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1671-1679
+SDValue VETargetLowering::legalizeInternalVectorOp(SDValue Op,
+                                                   SelectionDAG &DAG) const {
+  VECustomDAG CDAG(DAG, Op);
+  // TODO: Implement odd/even splitting.
+  return legalizePackedAVL(Op, CDAG);
+}
+
----------------
Why do you add these functions to VEISelLowering.cpp instead of VVPISelLowering.cpp which you implemented in local develop branch?  Those cause more conflicts at merge.  I appreciate if you follow what you implemented in local develop branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118321/new/

https://reviews.llvm.org/D118321