[PATCH] D118321: [VE] LEGALAVL and staged VVP legalization

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/VE/VECustomDAG.cpp:47
+  auto VVPOpc = getVVPOpcode(Op->getOpcode());
+  auto Opc = VVPOpc ? *VVPOpc : Op->getOpcode();
+
----------------
Can use Optional::getValueOr?


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1696
+
+    if (auto ConstAVL = dyn_cast<ConstantSDNode>(AVL)) {
+      LegalAVL = CDAG.getConstant((ConstAVL->getZExtValue() + 1) / 2, MVT::i32);
----------------
LLVM coding standards would prefer "auto *ConstAVL" so that the pointerness isn't hidden.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118321/new/

https://reviews.llvm.org/D118321