[PATCH] D116179: [InstrProf][NFC] Do not assume size of counter type

Tue Jan 18 17:27:54 PST 2022

MaskRay added a comment.

In D116179#3253146 <https://reviews.llvm.org/D116179#3253146>, @phosek wrote:

> Is it really necessary to rename the fields in `InstrProfData.inc`? That header is shipped with Clang and may have other uses outside of compiler-rt. For example, in Fuchsia we use `InstrProfData.inc` in the kernel where we cannot use the existing runtime and the name change broke our build. The original names may not be perfect, but that shouldn't justify breaking source compatibility.

(I tend to think that changing the name is fine since the type is changed and it serves as a hint that downstream needs to adjust their APIs, not causing lurking problems. By I am happy that my opinion is overridden by others who have strong opinions.)

(I'd probably not call the change NFC since APIs have been renamed.)

This is the kind of changes I hope that past coverage contributors like @davidxl, @phosek, @vsk can comment before landing...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116179/new/

https://reviews.llvm.org/D116179