[PATCH] D116179: [InstrProf][NFC] Do not assume size of counter type

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 16:59:36 PST 2022


phosek added a comment.

Is it really necessary to rename the fields in `InstrProfData.inc`? That header is shipped with Clang and may have other uses outside of compiler-rt. For example, in Fuchsia we use `InstrProfData.inc` in the kernel where we cannot use the existing runtime and the name change broke our build. The original names may not be perfect, but that shouldn't justify breaking source compatibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116179/new/

https://reviews.llvm.org/D116179



More information about the llvm-commits mailing list