[PATCH] D116179: [InstrProf][NFC] Do not assume size of counter type

Tue Jan 18 17:41:52 PST 2022

ellis added a comment.

In D116179#3253146 <https://reviews.llvm.org/D116179#3253146>, @phosek wrote:

> Is it really necessary to rename the fields in `InstrProfData.inc`? That header is shipped with Clang and may have other uses outside of compiler-rt. For example, in Fuchsia we use `InstrProfData.inc` in the kernel where we cannot use the existing runtime and the name change broke our build. The original names may not be perfect, but that shouldn't justify breaking source compatibility.

I've created D117631 <https://reviews.llvm.org/D117631> to restore `InstrProfData.inc` and hopefully fix your build. In retrospect I guess this wasn't NFC because this file is being used elsewhere, good to know.

By the way, I'm also changing this file in D116180 <https://reviews.llvm.org/D116180>, but I'm guessing that won't cause issues because it is only adding a bit field, not changing a field name.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116179/new/

https://reviews.llvm.org/D116179