[PATCH] D116179: [InstrProf][NFC] Do not assume size of counter type

Tue Jan 18 16:58:38 PST 2022

ellis added a comment.

In D116179#3253129 <https://reviews.llvm.org/D116179#3253129>, @leonardchan wrote:

> It looks like this (expectedly) broke our downstream builder (https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-debug/b8824668235249206913/overview). We can do a soft transition by checking against the clang git revision in our build, then setting a macro if the clang includes this change, then toggling between types based on the macro, but this seems pretty messy. For future commits, would this perhaps constitute an update to `INSTR_PROF_RAW_VERSION`? If that's mainly reserved for binary format changes, would it perhaps be a good idea to introduce a macro for source-level API changes? While the binary format hasn't changed, downstream projects that use `InstrProfData.inc` could break from stuff like this.

Hi @leonardchan, apologies for breaking your builder. Can you help me understand why changing `InstrProfData.inc` resulted in a build break? Does this mean any change to that file will break your builds?

The changes to `InstrProfData.inc` in this patch are pretty minimal (they are just renaming variables) and could easily be reverted. I'd rather to this than bumping the version.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116179/new/

https://reviews.llvm.org/D116179