[PATCH] D116179: [InstrProf][NFC] Do not assume size of counter type
Leonard Chan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 18 16:48:29 PST 2022
leonardchan added a comment.
It looks like this (expectedly) broke our downstream builder (https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-debug/b8824668235249206913/overview). We can do a soft transition by checking against the clang git revision in our build, then setting a macro if the clang includes this change, then toggling between types based on the macro, but this seems pretty messy. For future commits, would this perhaps constitute an update to `INSTR_PROF_RAW_VERSION`? If that's mainly reserved for binary format changes, would it perhaps be a good idea to introduce a macro for source-level API changes? While the binary format hasn't changed, downstream projects that use `InstrProfData.inc` could break from stuff like this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116179/new/
https://reviews.llvm.org/D116179
More information about the llvm-commits
mailing list