[PATCH] D115749: [WebAssembly] Emit symbol labels for table global symbols

[Paulo Matos via Phabricator via llvm-commits]

pmatos added a comment.

@sbc100 Unfortunately while adding some tests to this including testing private IR globals, which don't emit a `.globl` for the symbol I found a crash, which I now fixed and an issue with multiple globals in the same compilation unit. For example, two tables don't work because `.tabletype` is only emitted for the first. `emitLinkage` is called on each symbol in turn, and `emitExternalDecls` emits the tabletype for the symbol, however it only runs for the first symbol because `emitExternalDecls` only actually runs the first time it's called. This is very unfortunately and will need a bit of refactoring. I am working on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115749/new/

https://reviews.llvm.org/D115749