[PATCH] D115749: [WebAssembly] Emit symbol labels for table global symbols
Paulo Matos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 17 07:26:13 PST 2022
pmatos updated this revision to Diff 400550.
pmatos added a comment.
Refactored places where type related utility functions are and refactored some of the symbol type creation.
Noticed some issues with generating duplicate .tabletype which was fixed by moving emitExternalDecls to onFinalization. However, this doesn't seem like a good solution since the .*type directives need to show up before being used, and therefore cannot come at the end of the file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115749/new/
https://reviews.llvm.org/D115749
Files:
llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.cpp
llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.h
llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.cpp
llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h
llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.h
llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp
llvm/lib/Target/WebAssembly/WebAssemblyLowerRefTypesIntPtrConv.cpp
llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp
llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.h
llvm/test/CodeGen/WebAssembly/externref-tableget.ll
llvm/test/CodeGen/WebAssembly/externref-tableset.ll
llvm/test/CodeGen/WebAssembly/funcref-table_call.ll
llvm/test/CodeGen/WebAssembly/funcref-tableget.ll
llvm/test/CodeGen/WebAssembly/funcref-tableset.ll
llvm/test/CodeGen/WebAssembly/table-types.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115749.400550.patch
Type: text/x-patch
Size: 21800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220117/1ed05b10/attachment-0001.bin>
More information about the llvm-commits
mailing list