[PATCH] D117844: [AMDGPU] Prevent aliasing of SrcC and Dst in MAI

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D117844#3261629 <https://reviews.llvm.org/D117844#3261629>, @rampitec wrote:

> In D117844#3260700 <https://reviews.llvm.org/D117844#3260700>, @foad wrote:
>
>> I don't understand the need for the new GCNPreRaFixups pass. Isn't this //exactly// what TwoAddressInstruction does, when it calls the target's convertToThreeAddress?
>
> A call to convertToThreeAddress is an optimization and not guaranteed as far as I understand.

I would suggest instruction selecting to the version with tied operands, and then letting TwoAddressInstruction decide whether to call your convertToThreeAddress, which would convert it to the earlyclobber form.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117844/new/

https://reviews.llvm.org/D117844