[PATCH] D117432: [RISCV] Implement support for the Zicbom and Zicboz extensions

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicbo.td:19
+class CBO_r<bits<12> optype, string opcodestr>
+    : RVInstI<0b010, OPC_MISC_MEM, (outs), (ins GPR:$rs1),
+              opcodestr, "$rs1"> {
----------------
Ugh, this takes the encoding that people have been using for RV128I's LQ for years (riscvemu's implementation uses that), and we've been using that as a result for our 128-bit capability load/store instructions... guess we'll just have to be incompatible and stomp on this encoding downstream :(


================
Comment at: llvm/test/MC/RISCV/rv32zicbom-invalid.s:17
+
+# Instructions from other zicbo* extensions aren't avalable with enabling the
+# appropriate -mattr flag.
----------------
(and copied to ...z/p-invalid.s)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117432/new/

https://reviews.llvm.org/D117432