[PATCH] D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library.

Stella Laurenzo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 17:37:44 PST 2022


stellaraccident created this revision.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
stellaraccident requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.

This is important because *Objects targets need to only depend on other *Objects targets, not on the unsuffixed CAPI rules. Depending on how it is linked in the current setup, it can cause duplicate symbols.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117176

Files:
  utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
  utils/bazel/llvm-project-overlay/mlir/build_defs.bzl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117176.399520.patch
Type: text/x-patch
Size: 5887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220113/88790015/attachment.bin>


More information about the llvm-commits mailing list