[PATCH] D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library.

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey accepted this revision.
GMNGeoffrey added a comment.
This revision is now accepted and ready to land.

This LGTM, but I would wait for Peter to weigh in to make sure.



================
Comment at: utils/bazel/llvm-project-overlay/mlir/build_defs.bzl:34
         header_deps = [],
+        capi_deps = [],
         **kwargs):
----------------
Can you document this argument? I think we're getting in to the territory of non-obvious on this one. I would probably just bite the bullet and do the standard "Args:" block, but mostly because I'm used to linters complaining if I don't do exactly that. I would say that header_deps and capi_deps are worth documenting here, at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117176/new/

https://reviews.llvm.org/D117176