[PATCH] D115749: [WebAssembly] Emit symbol labels for table global symbols

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 03:40:37 PST 2022


pmatos updated this revision to Diff 398894.
pmatos added a comment.

Simplified code to emit labels for tables and tabletype directive.

@sbc100 not emitting .globl for tables since i think those are not necessary given .tabletype. Is this the case? That's the reason why I am not calling emitLinkage if the symbol is a table in emitGlobalVariable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115749/new/

https://reviews.llvm.org/D115749

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
  llvm/test/CodeGen/WebAssembly/externref-tableget.ll
  llvm/test/CodeGen/WebAssembly/externref-tableset.ll
  llvm/test/CodeGen/WebAssembly/funcref-table_call.ll
  llvm/test/CodeGen/WebAssembly/funcref-tableget.ll
  llvm/test/CodeGen/WebAssembly/funcref-tableset.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115749.398894.patch
Type: text/x-patch
Size: 4346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220111/f178a89d/attachment.bin>


More information about the llvm-commits mailing list