[PATCH] D115749: [WebAssembly] Emit symbol labels for table global symbols

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:202
+    // If the GlobalVariable refers to a table, we handle it here instead of
+    // in emitExternalDecls
+    if (Sym->isTable()) 
----------------
Are you saying that for undefined/external tables we call `emitTableType` elsewhere?   IIUC the table type needs to be declared ragardless of whether the table has a definition (hasInitializer()) or not, right?

This comment seems a little odd to me given that the code below doesn't just handle table symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115749/new/

https://reviews.llvm.org/D115749