[PATCH] D116737: [DAG][AArch64][SVE] Fix VLS mulh code generation

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 6 09:49:22 PST 2022


paulwalker-arm added a comment.

Whilst not wrong this looks like something that should be canonicalised earlier.  Is it possible to add this logic to `SelectionDAG::getVectorShuffle()` and utilise `SelectionDAG::getConstant()`? I ask because there are several functions of `isConstOrConstSplat`'s ilk and we don't really want to have to add similar support to all of them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116737/new/

https://reviews.llvm.org/D116737



More information about the llvm-commits mailing list