[PATCH] D116737: [DAG][AArch64][SVE] Fix VLS mulh code generation

[David Truby via Phabricator via llvm-commits]

DavidTruby added a comment.

In D116737#3225594 <https://reviews.llvm.org/D116737#3225594>, @paulwalker-arm wrote:

> Whilst not wrong this looks like something that should be canonicalised earlier.  Is it possible to add this logic to `SelectionDAG::getVectorShuffle()` and utilise `SelectionDAG::getConstant()`? I ask because there are several functions of `isConstOrConstSplat`'s ilk and we don't really want to have to add similar support to all of them.

I'm not 100% sure what you mean here so I thought I ought to check; do you mean that `SelectionDAG::getVectorShuffle()` should return a BUILD_VECTOR generated using `SelectionDAG::getConstant()` in cases like this where the vector shuffle is a constant splat?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116737/new/

https://reviews.llvm.org/D116737