[PATCH] D116019: [RISCV][NFC] Use foreach to refactor vector load/store whole register instructions' definition.
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 6 02:42:12 PST 2022
asb added a comment.
Thanks for the patch Jianjian. This is a matter of personal taste, so I'll happily defer to those who are more actively contributing to the RVV tablegen files, but IMHO the reduced readability due to the casts and string concatenation in the new version mean it's not clear this is an improvement over the current code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116019/new/
https://reviews.llvm.org/D116019
More information about the llvm-commits
mailing list