[PATCH] D116463: [SPIRV 4/6] Add target lowerling, TargetMachine and AsmPrinter

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov added a comment.

Yes, some missing features will be added later. What about frame lowering, the SPIRV target is very special: it uses only virtual registers. It does not operate with stack frame explicitly and does not generate a function prologue/epilogue. So it does not actually utilize frame lowering and we do not plan to add more functionality there.



================
Comment at: llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp:44
+
+#if 0
+bool SPIRVTargetLowering::getTgtMemIntrinsic(IntrinsicInfo &Info,
----------------
rengolin wrote:
> Don't keep code commented out in patches. If you need this somewhere, keep it local and reapply later when it makes sense to do so.
Sorry, it will be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463