[PATCH] D116463: [SPIRV 4/6] Add target lowerling, TargetMachine and AsmPrinter
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 1 13:23:47 PST 2022
rengolin added a comment.
I'm guessing that the missing bits (ex. frame lowering) will be implemented in following patches.
================
Comment at: llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp:44
+
+#if 0
+bool SPIRVTargetLowering::getTgtMemIntrinsic(IntrinsicInfo &Info,
----------------
Don't keep code commented out in patches. If you need this somewhere, keep it local and reapply later when it makes sense to do so.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116463/new/
https://reviews.llvm.org/D116463
More information about the llvm-commits
mailing list