[PATCH] D116463: [SPIRV 4/6] Add target lowerling, TargetMachine and AsmPrinter

Sun Jan 2 07:10:19 PST 2022

rengolin added a comment.

In D116463#3216168 <https://reviews.llvm.org/D116463#3216168>, @iliya-diyachkov wrote:

> Yes, some missing features will be added later. What about frame lowering, the SPIRV target is very special: it uses only virtual registers. It does not operate with stack frame explicitly and does not generate a function prologue/epilogue. So it does not actually utilize frame lowering and we do not plan to add more functionality there.

I suspected as much. So it would be nice to add a comment there saying these are not used because of the SPIRV lowering.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463