[PATCH] D115642: [CSSPGO] Warn instead of error out for modules that are not probed.

Mon Dec 13 22:23:39 PST 2021

hoy added a comment.

In D115642#3191214 <https://reviews.llvm.org/D115642#3191214>, @wenlei wrote:

>> Modules not compiled with probe should not have its functions show up in the profile, thus the profile file will not be loaded and the error should not be triggered.
>
> My point is that modules not compiled with probe should not have `fprofile-sample-use` at all. If `fprofile-sample-use` is specified and csspgo profile is used, then we expect probe flag to be on too. Is that assumption not true? That is the underlying problem I'm getting at.

Right, they currently do not have the profile passed in during clang compilation, ie. LTO prelink. What failed for me was LTO postlink, where the profile is shared by all modules. So in your case, the failure happened in prelink?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115642/new/

https://reviews.llvm.org/D115642