[PATCH] D115642: [CSSPGO] Warn instead of error out for modules that are not probed.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 21:13:55 PST 2021


wenlei added a comment.

> Modules not compiled with probe should not have its functions show up in the profile, thus the profile file will not be loaded and the error should not be triggered.

My point is that modules not compiled with probe should not have `fprofile-sample-use` at all. If `fprofile-sample-use` is specified and csspgo profile is used, then we expect probe flag to be on too. Is that assumption not true? That is the underlying problem I'm getting at.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115642/new/

https://reviews.llvm.org/D115642



More information about the llvm-commits mailing list