[PATCH] D115642: [CSSPGO] Warn instead of error out for modules that are not probed.

Tue Dec 14 16:24:31 PST 2021

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

In D115642#3191292 <https://reviews.llvm.org/D115642#3191292>, @hoy wrote:

> In D115642#3191214 <https://reviews.llvm.org/D115642#3191214>, @wenlei wrote:
>
>>> Modules not compiled with probe should not have its functions show up in the profile, thus the profile file will not be loaded and the error should not be triggered.
>>
>> My point is that modules not compiled with probe should not have `fprofile-sample-use` at all. If `fprofile-sample-use` is specified and csspgo profile is used, then we expect probe flag to be on too. Is that assumption not true? That is the underlying problem I'm getting at.
>
> Right, they currently do not have the profile passed in during clang compilation, ie. LTO prelink, as far as I see. What failed for me was LTO postlink, where the profile was shared by all modules. So in your case, the failure happened in prelink?

Ok, can you update the description then? It doesn't seem related to importing. It's an error with some modules for the same LTO build not having probe flag, but still using the same csspgo profile at post link.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115642/new/

https://reviews.llvm.org/D115642