[PATCH] D115217: [NFC][MachineFunction] Rename APIs to conform to coding style

Mon Dec 6 22:28:23 PST 2021

mtrofin abandoned this revision.
mtrofin added a comment.

In D115217#3175465 <https://reviews.llvm.org/D115217#3175465>, @jrtc27 wrote:

> Is this really worth it? It's churn for downstreams, and has little gain given this is a drop in the ocean for old code style. The LLVM Coding Standards also say:
>
>> [...] we explicitly do not want patches that do large-scale reformatting of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way. Please commit such changes separately to make code review easier.
>
> so, unless you're planning large-scale refactoring of the APIs (which seems unlikely), that reads to me as "don't".

It was *very* easy to do (straight-forward, automated refactoring), so I figured I'd put it up see what people think. I wasn't aware of the explicit pushback against large-scale refactorings (thanks for pointing that out!). I can definitely piecemeal it.

Unless I'm missing something, I'm not sure how to think about the downstream aspect, nor the relative amount of old/new code styles. I could see those arguments raised vis-a-vis any API refactoring patch, and IIRC, we've generally been doing API cleanups.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115217/new/

https://reviews.llvm.org/D115217