[PATCH] D115217: [NFC][MachineFunction] Rename APIs to conform to coding style

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 22:06:33 PST 2021


jrtc27 added a comment.

Is this really worth it? It's churn for downstreams, and has little gain given this is a drop in the ocean for old code style. The LLVM Coding Standards also say:

> [...] we explicitly do not want patches that do large-scale reformatting of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way. Please commit such changes separately to make code review easier.

so, unless you're planning large-scale refactoring of the APIs (which seems unlikely), that reads to me as "don't".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115217/new/

https://reviews.llvm.org/D115217



More information about the llvm-commits mailing list