[PATCH] D115217: [NFC][MachineFunction] Rename APIs to conform to coding style

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 00:21:29 PST 2021


foad added a comment.

In D115217#3175465 <https://reviews.llvm.org/D115217#3175465>, @jrtc27 wrote:

> Is this really worth it? It's churn for downstreams, and has little gain given this is a drop in the ocean for old code style. The LLVM Coding Standards also say:

Just to put the opposite point of view, I'm quite happy with refactoring patches like this, even though I also have to deal with downstream merge conflicts.

It would be a bit easier to resolve any conflicts if you could say //exactly// how you made these changes -- hopefully the answer is something simple like "I just ran git clang-format"!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115217/new/

https://reviews.llvm.org/D115217



More information about the llvm-commits mailing list