[PATCH] D115128: [TableGen][CodeEmitter] Introducing the VarLenCodeEmitterGen infrastructure

[Ricky Taylor via Phabricator via llvm-commits]

ricky26 accepted this revision.
ricky26 added a comment.
This revision is now accepted and ready to land.

LGTM. There's one comment that I think might be wrong. This is cool to see and I favour it much more than the existing code beads, IMO it's much more readable. Thanks! :)



================
Comment at: llvm/include/llvm/Target/Target.td:761
+///     (descend 0b0110, 0b1101)
+/// This results in an encoding of 0b01101101.
+def descend;
----------------
These two examples seem to be the same.


================
Comment at: llvm/utils/TableGen/VarLenCodeEmitterGen.cpp:66
+
+void VarLenCodeEmitterGen::VarLenInst::buildRec(const DagInit *DI) {
+  auto Op = DI->getOperator()->getAsString();
----------------
Not really anything worth changing now (mostly a note to myself if I come to write a disassembler generator for this):
It might be worth coalescing neighbouring constant bits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115128/new/

https://reviews.llvm.org/D115128