[PATCH] D115128: [TableGen][CodeEmitter] Introducing the VarLenCodeEmitterGen infrastructure

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

In D115128#3187446 <https://reviews.llvm.org/D115128#3187446>, @ricky26 wrote:

> LGTM. There's one comment that I think might be wrong. This is cool to see and I favour it much more than the existing code beads, IMO it's much more readable. Thanks! :)

Thank you for taking a look. I'll address those comments later. Meanwhile when I was refactoring other instructions (more specifically, control instructions that has pc-relative immediate) I found that your encoder idea is actually useful (using a custom encoder only on immediate that can be pc-relative). I'll push a separate review to add that feature.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115128/new/

https://reviews.llvm.org/D115128