[PATCH] D115128: [TableGen][CodeEmitter] Introducing the VarLenCodeEmitterGen infrastructure

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 05:54:56 PST 2021


myhsu updated this revision to Diff 393128.
myhsu added a comment.

Incorporated feedbacks from @ricky26 :

- Replacing `seq` and `seq:$dec` with `ascend` and `descend`, respectively. The reason I picked these two words is because I want them to be more explicit on their placement directions (i.e. LSB->MSB and MSB->LSB).
- Replacing the `operand` operator in variant `(operand "$foo", 8, 7)` with `slice` operator.

I didn't incorporate the custom encoder idea we discussed on the mailing list because so far no one is using it and I want to make the patch as minimal as possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115128/new/

https://reviews.llvm.org/D115128

Files:
  llvm/include/llvm/Target/Target.td
  llvm/test/TableGen/VarLenEncoder.td
  llvm/utils/TableGen/CMakeLists.txt
  llvm/utils/TableGen/CodeEmitterGen.cpp
  llvm/utils/TableGen/VarLenCodeEmitterGen.cpp
  llvm/utils/TableGen/VarLenCodeEmitterGen.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115128.393128.patch
Type: text/x-patch
Size: 32962 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211209/4e0f6393/attachment-0001.bin>


More information about the llvm-commits mailing list