[PATCH] D114305: [Demangle] Add support for multiple identifiers in D qualified names
Luís Ferreira via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 26 07:05:57 PST 2021
ljmf00 added a comment.
In D114305#3154851 <https://reviews.llvm.org/D114305#3154851>, @dblaikie wrote:
> In D114305#3154699 <https://reviews.llvm.org/D114305#3154699>, @ljmf00 wrote:
>
>> Done @dblaikie, can you review?
>
> Oh, generally if something's "Approved with suggestions" it's fine to submit it if you think you've applied the suggestions. So, this is fine, but I'll mark it as approved again.
Yeah, I don't have permission to land it, but thanks for letting me know that. A bit offtopic, but what are the rules to apply for commit access? I believe it is early to request that, although.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114305/new/
https://reviews.llvm.org/D114305
More information about the llvm-commits
mailing list