[PATCH] D114305: [Demangle] Add support for multiple identifiers in D qualified names

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

In D114305#3154699 <https://reviews.llvm.org/D114305#3154699>, @ljmf00 wrote:

> Done @dblaikie, can you review?

Oh, generally if something's "Approved with suggestions" it's fine to submit it if you think you've applied the suggestions. So, this is fine, but I'll mark it as approved again.



================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:201-205
+  size_t NotFirst = false;
+  do {
+    if (NotFirst)
+      *Demangled << '.';
+    NotFirst = true;
----------------
I'd probably make this "First" rather than "NotFirst" - might be a bit clearer/more direct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114305/new/

https://reviews.llvm.org/D114305