[PATCH] D114305: [Demangle] Add support for multiple identifiers in D qualified names

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D114305#3155925 <https://reviews.llvm.org/D114305#3155925>, @ljmf00 wrote:

> In D114305#3154851 <https://reviews.llvm.org/D114305#3154851>, @dblaikie wrote:
>
>> In D114305#3154699 <https://reviews.llvm.org/D114305#3154699>, @ljmf00 wrote:
>>
>>> Done @dblaikie, can you review?
>>
>> Oh, generally if something's "Approved with suggestions" it's fine to submit it if you think you've applied the suggestions. So, this is fine, but I'll mark it as approved again.
>
> Yeah, I don't have permission to land it, but thanks for letting me know that. A bit offtopic, but what are the rules to apply for commit access? I believe it is early to request that, although.

Generally once you've had a few patches approved, you can request pre-review commit access ( https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access - though the documentation might be a bit out of date, I'd probably still email Chris and he can bounce it to whomever & maybe update the docs) & then you sort of play it by ear - anything that you have a pretty good estimate will be trivially approved, you can eventually commit without pre-commit review (& be responsive to post-commit review).

> **EDIT:** It is not landable yet, as it has dependencies not yet approved

Ah, cool - just ping here if you need me to commit it when it comes time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114305/new/

https://reviews.llvm.org/D114305