[PATCH] D114449: [ARM] Make v2i1 legal

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added a comment.

LGTM with a couple of changes



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:8362
+  case MVT::v2i1:
+    return MVT::v2f64;
   case MVT::v4i1:
----------------
How comes this is `f64` and not `i64`? Is `i64` not a valid element type for this?


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:8444
   // Now return the result of comparing the shuffled vector with zero,
   // which will generate a real predicate, i.e. v4i1, v8i1 or v16i1.
+  if (VT == MVT::v2i1) {
----------------
It would be useful to update the comment here to include `v2i1`


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:8951
     // Now return the result of comparing the subvector with zero,
     // which will generate a real predicate, i.e. v4i1, v8i1 or v16i1.
+    if (VT == MVT::v2i1) {
----------------
Same here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114449/new/

https://reviews.llvm.org/D114449