[PATCH] D114449: [ARM] Make v2i1 legal

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 05:52:52 PST 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:8362
+  case MVT::v2i1:
+    return MVT::v2f64;
   case MVT::v4i1:
----------------
samtebbs wrote:
> How comes this is `f64` and not `i64`? Is `i64` not a valid element type for this?
It was originally because a f64 lane extract (into a D register) can be simpler than using a i64 register (which is not going to be legal). So the f64 shuffles and whatnot would be simpler. I don't think that's necessary from the tests, but it sounds a little better to keep them as legal types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114449/new/

https://reviews.llvm.org/D114449



More information about the llvm-commits mailing list