[PATCH] D114460: [fir] Add fir reduction builder

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: flang/include/flang/Optimizer/Builder/Runtime/Reduction.h:21
+
+/// Generate call to all runtime routine.
+/// This calls the descriptor based runtime call implementation of the all
----------------
clementval wrote:
> awarzynski wrote:
> > rovka wrote:
> > > Should we use backticks or something around function names? It reads really strange otherwise.
> > > Also, isn't this actually AllDim?
> > > Should we use backticks or something around function names? 
> > +1
> > 
> > Also, what is the difference between `genAllDescriptor` and `genAll`? Why do we need both?
> The comments are pretty clear on the differences. 
But to clarify: the runtime sometimes has different entry points for the same intrinsic, for special cases. In this case, IIUC, there's All and AllDim, both of which implement the ALL intrinsic. If you look in the standard, you'll see there's 2 variants: ALL(MASK) or ALL(MASK, DIM).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460