[PATCH] D114460: [fir] Add fir reduction builder

Wed Nov 24 12:44:45 PST 2021

clementval added a comment.

In D114460#3151536 <https://reviews.llvm.org/D114460#3151536>, @kiranchandramohan wrote:

> If `RuntimeCalltestBase` can be factored out into a separate patch, the other patches can be tested or reviewed independently.

Should I move `flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h` as well to the initial patch? It would makes sense since all other need this file.

================
Comment at: flang/include/flang/Optimizer/Builder/Runtime/Reduction.h:21
+
+/// Generate call to all runtime routine.
+/// This calls the descriptor based runtime call implementation of the all
----------------
awarzynski wrote:
> rovka wrote:
> > Should we use backticks or something around function names? It reads really strange otherwise.
> > Also, isn't this actually AllDim?
> > Should we use backticks or something around function names? 
> +1
> 
> Also, what is the difference between `genAllDescriptor` and `genAll`? Why do we need both?
The comments are pretty clear on the differences. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460