[PATCH] D114460: [fir] Add fir reduction builder

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 01:27:35 PST 2021


kiranchandramohan added a comment.

In D114460#3152380 <https://reviews.llvm.org/D114460#3152380>, @clementval wrote:

> In D114460#3151536 <https://reviews.llvm.org/D114460#3151536>, @kiranchandramohan wrote:
>
>> If `RuntimeCalltestBase` can be factored out into a separate patch, the other patches can be tested or reviewed independently.
>
> Should I move `flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h` as well to the initial patch? It would makes sense since all other need this file.

Yes, that would be good. You can cite other patches which are consumers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460



More information about the llvm-commits mailing list