[PATCH] D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4550
+  return false;
+}
+
----------------
Maybe better to pull this into haveNoCommonBitsSet as lambda?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4562
+        matchNoCommonBitsPattern(B->getOperand(1), A))
+      return true;
+  }
----------------
You need to try and ensure we have test coverage for all of these permutations.


================
Comment at: llvm/test/CodeGen/X86/or-lea.ll:154
+  ret i16 %inc
+}
----------------
Once you have more test coverage, we should add these tests to trunk with current codegen so you can rebase and the patch shows the diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113970/new/

https://reviews.llvm.org/D113970