[PATCH] D113959: [llvm][RISC-V] Use floating-point ABI by default if possible
Oi Chee Cheung via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 15 18:01:55 PST 2021
occheung added a comment.
In D113959#3133528 <https://reviews.llvm.org/D113959#3133528>, @jrtc27 wrote:
> How did you update the tests; did you search for all that enabled f and d, or did you just look for ones that failed? Just wondering if there's any subtlety there about tests that appear to be unchanged but end up following slightly different code paths from what they intend to test.
I looked for the ones that failed without specifying abi and then added the -target-abi ilp32 / lp64 argument.
Regardless of what the intended test were, llc will use ilp32/lp64 as default abi before patch, so I don't think setting -target-abi as that intended default values (before patch) actually changed the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113959/new/
https://reviews.llvm.org/D113959
More information about the llvm-commits
mailing list