[PATCH] D113959: [llvm][RISC-V] Use floating-point ABI by default if possible

Mon Nov 15 18:08:17 PST 2021

jrtc27 added a comment.

In D113959#3133540 <https://reviews.llvm.org/D113959#3133540>, @occheung wrote:

> In D113959#3133528 <https://reviews.llvm.org/D113959#3133528>, @jrtc27 wrote:
>
>> How did you update the tests; did you search for all that enabled f and d, or did you just look for ones that failed? Just wondering if there's any subtlety there about tests that appear to be unchanged but end up following slightly different code paths from what they intend to test.
>
> I looked for the ones that failed without specifying abi and then added the -target-abi ilp32 / lp64 argument.
> Regardless of what the intended test were, llc will use ilp32/lp64 as default abi before patch, so I don't think setting -target-abi as that intended default values (before patch) actually changed the test.

That's not what I'm concerned about; clearly those have no change in behaviour. It's the ones that _still_ use the computed default ABI that may now have changed for them but happen to not change the output; just because the output is the same doesn't mean the test is still testing the same thing. It's probably fine, but I'm just raising it as a potential concern to think about.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113959/new/

https://reviews.llvm.org/D113959