[PATCH] D113959: [llvm][RISC-V] Use floating-point ABI by default if possible

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D113959#3133525 <https://reviews.llvm.org/D113959#3133525>, @craig.topper wrote:

> In D113959#3133522 <https://reviews.llvm.org/D113959#3133522>, @jrtc27 wrote:
>
>> I believe this is the consensus in https://github.com/riscv-non-isa/riscv-toolchain-conventions/issues/13 (which should be linked to). Do you know if GCC is doing the same? Because even if a certain default makes more sense than another, it's best to be consistent between toolchains to avoid surprises.
>
> Isn't clang behavior determined by riscv::getRISCVABI in clang/lib/Driver/ToolChains/Arch/RISCV.cpp rather than this code?

Oh, indeed, that's still separate. I'm in two minds as to whether llc should default to soft-float or base it on the attributes (ignoring the F-without-D default for now). Being consistent with clang has its benefits, but normally you want llc to be simple and not have it start changing behaviour in other ways when you just add an attribute...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113959/new/

https://reviews.llvm.org/D113959